This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1798: Dynamic partitioning occasionally fails.#709
Closed
blrunner wants to merge 6 commits intoapache:masterfrom
Closed
TAJO-1798: Dynamic partitioning occasionally fails.#709blrunner wants to merge 6 commits intoapache:masterfrom
blrunner wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
I converted List to Set for avoiding duplicated partitions. And after stored partitions to catalog, cleared all Set instances. |
…into TAJO-1798
Member
|
Could you add tests ? |
Contributor
Author
|
Thanks @jinossy |
Member
|
Your change mainly appears to focus on partition bugs. Only this line (https://github.com/apache/tajo/pull/709/files#diff-f6cacc8f5447d717968f06d0b133f171L530) is related to the issue title. So, this issue would be more searchable if this issue title is changed into a better one. |
blrunner
changed the title
Contributor
Author
|
Thanks @hyunsik |
Member
|
+1 LGTM |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I verified this patch with TPC-H 1G.