This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1707: Rack local count can be more than actual number of tasks.#717
Closed
jinossy wants to merge 3 commits intoapache:masterfrom
Closed
TAJO-1707: Rack local count can be more than actual number of tasks.#717jinossy wants to merge 3 commits intoapache:masterfrom
jinossy wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
|
I've remove the cancellation count |
…into TAJO-1707
Contributor
|
This patch looks good, but totalAssigned is the sum of only hostLocalAssigned and rackLocalAssigned. How about adding a new variable to keep the total number of attempts including cancelled attempts? |
Member
Author
|
Good idea. I'm going to add totalAttempts |
Contributor
|
+1 LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.