This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1739: Add a statement for adding partition to TajoDump#734
Closed
blrunner wants to merge 10 commits into
Closed
TAJO-1739: Add a statement for adding partition to TajoDump#734blrunner wants to merge 10 commits into
blrunner wants to merge 10 commits into
Conversation
…into TAJO-1739
…into TAJO-1739
…into TAJO-1739
Contributor
There was a problem hiding this comment.
Every message for rpc communication with catalog should locate in CatalogProtocol.proto.
Contributor
There was a problem hiding this comment.
You seem to move this message to here to use in TajoMasterClientProtocol. If so, rename it like other messages.
Contributor
Author
|
I reflected your comments. |
Contributor
|
I missed that AbstractDBStore.getPartitions() already throws UndefinedTableException and UndefinedDatabaseException properly. Sorry for the last comment. |
Contributor
|
+1 looks good to me! |
Contributor
Author
|
Thanks @jihoonson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a statement for adding partition to TajoDump