This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1824: Remove partition_keys table from information_schema#743
Closed
blrunner wants to merge 8 commits into
Closed
TAJO-1824: Remove partition_keys table from information_schema#743blrunner wants to merge 8 commits into
blrunner wants to merge 8 commits into
Conversation
Member
There was a problem hiding this comment.
I think that this test is not necessary.
Member
|
This change looks straightforward. So, the added unit test is not necessary. |
Contributor
Author
|
Thanks @hyunsik I've just removed the unit test. |
…into TAJO-1824
…into TAJO-1824
…into TAJO-1824
Member
|
+1 |
…into TAJO-1824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting partition keys is not necessary because partitions are searched with its partition name. It would be better to remove from information_schema.