Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1907: Reduce the size of the INDEXES table's COLUMN_NAMES field#800

Closed
jihoonson wants to merge 1 commit into
apache:masterfrom
jihoonson:TAJO-1907
Closed

TAJO-1907: Reduce the size of the INDEXES table's COLUMN_NAMES field#800
jihoonson wants to merge 1 commit into
apache:masterfrom
jihoonson:TAJO-1907

Conversation

@jihoonson
Copy link
Copy Markdown
Contributor

No description provided.

@jihoonson
Copy link
Copy Markdown
Contributor Author

MySQL InnoDB allows the size of a single column for an index key up to 767 bytes by default.
Please refer to this document. https://dev.mysql.com/doc/refman/5.5/en/innodb-restrictions.html

@jihoonson
Copy link
Copy Markdown
Contributor Author

Without this patch, users will face an error message like Specified key was too long; max key length is 767. when starting up the tajo master. This patch must be included in the 0.11.0 release, I think.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 7, 2015

+1
This change makes sense. The patch looks good to me. I'll cancel the vote due to this reason. Thanks!

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 7, 2015

I have a question. Should users backup and restore for it? If so, please share the breaking change in dev/user mailing list.

@jihoonson
Copy link
Copy Markdown
Contributor Author

Yes, I think it will be ok. Users don't have to backup and restore their catalog unless they have indexes on some columns where the length of the composite string of those column names is 256 bytes.

@jihoonson
Copy link
Copy Markdown
Contributor Author

I'll commit shortly.

@asfgit asfgit closed this in 829d83a Oct 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants