This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1909: Eliminate remained explicit diamond expressions#802
Closed
dkhwangbo wants to merge 11 commits into
Closed
TAJO-1909: Eliminate remained explicit diamond expressions#802dkhwangbo wants to merge 11 commits into
dkhwangbo wants to merge 11 commits into
Conversation
Contributor
Author
|
Travis-ci gives me the error message but This commit pass the same test in my local environment. |
Member
|
That's not your fault. I'll manually verify the patch and review it. |
Member
|
Could you rebase the patch? The patch causes the following error: #778 changes the source and target JVM of tajo-common to 1.7. It may cause this problem, I think. |
Contributor
Author
|
@hyunsik Thanks for your reply. I rebase it. Please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some remain part after working TAJO-1844.
This is another work of removing it.