Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1909: Eliminate remained explicit diamond expressions#802

Closed
dkhwangbo wants to merge 11 commits into
apache:masterfrom
dkhwangbo:TAJO-1909
Closed

TAJO-1909: Eliminate remained explicit diamond expressions#802
dkhwangbo wants to merge 11 commits into
apache:masterfrom
dkhwangbo:TAJO-1909

Conversation

@dkhwangbo
Copy link
Copy Markdown
Contributor

I found some remain part after working TAJO-1844.
This is another work of removing it.

@dkhwangbo
Copy link
Copy Markdown
Contributor Author

Travis-ci gives me the error message but This commit pass the same test in my local environment.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 7, 2015

That's not your fault. I'll manually verify the patch and review it.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Oct 7, 2015

Could you rebase the patch? The patch causes the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project tajo-common: Compilation failure
[ERROR] /home/hyunsik/Code/tajo/tajo/tajo-common/src/main/java/org/apache/tajo/util/ShutdownHookManager.java:[103,34] incompatible types: java.util.Set<java.lang.Object> cannot be converted to java.util.Set<org.apache.tajo.util.ShutdownHookManager.HookEntry>

#778 changes the source and target JVM of tajo-common to 1.7. It may cause this problem, I think.

@dkhwangbo
Copy link
Copy Markdown
Contributor Author

@hyunsik Thanks for your reply. I rebase it. Please review again.

@asfgit asfgit closed this in 5d470bc Oct 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants