This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1850: Using TUtil.newHash(Set/Map) should be replaced by Java's diamond operator#818
Closed
dkhwangbo wants to merge 3 commits intoapache:masterfrom
Closed
TAJO-1850: Using TUtil.newHash(Set/Map) should be replaced by Java's diamond operator#818dkhwangbo wants to merge 3 commits intoapache:masterfrom
dkhwangbo wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
The patch looks good to me. I manually tested it. It passed all unit tests. Could you remove TUtil::newHash method too? |
Contributor
Author
|
OK. I'll do that and commit again soon. |
Member
|
I missed to check out TUtil class. Here is my +1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the title. We introduced Java 7. We don't need TUtil.newHash(Set|Map) utility methods anymore. We need to eliminate them.
This commit pass all the test with mvn clean install.