This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1954: Fix memory leak in physical operator.#838
Closed
jinossy wants to merge 3 commits into
Closed
Conversation
Contributor
|
+1 LGTM! |
Contributor
There was a problem hiding this comment.
@jinossy I have a question? Do we need check null check for aggregateExecs?
Member
Author
There was a problem hiding this comment.
@charsyam
I refer to close() but It seems to the unnecessary checking. Are you working on this operator ?
Contributor
There was a problem hiding this comment.
@jinossy I'm sorry.
I tested below code. and it causes NPE.
List<String> lists = null;
for(String a : lists) {
}I think null checking is needed. sorry to disturb you.
Member
Author
There was a problem hiding this comment.
PhysicalPlannerImpl.createSortAggregationDistinctGroupbyExec always set the array, so it can not occurs NPE.
Next time, I will refactor these code.
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.