Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-1963: Add more configuration descriptions to document#844

Closed
jihoonson wants to merge 7 commits intoapache:masterfrom
jihoonson:TAJO-1963
Closed

TAJO-1963: Add more configuration descriptions to document#844
jihoonson wants to merge 7 commits intoapache:masterfrom
jihoonson:TAJO-1963

Conversation

@jihoonson
Copy link
Contributor

I also fixed a wrong configuration name.

@jihoonson
Copy link
Contributor Author

You can see the updated document here.
http://people.apache.org/~jihoonson/tajo-docs/configuration/tajo-site-xml.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, 'property value type' looks clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good comment.

@eminency
Copy link
Contributor

eminency commented Nov 6, 2015

I leave some comments.

@jihoonson
Copy link
Contributor Author

Thanks for your comment. I addressed your comments.

@eminency
Copy link
Contributor

eminency commented Nov 7, 2015

Thanks, it looks good. +1

@hyunsik
Copy link
Member

hyunsik commented Nov 9, 2015

Could check the unit test?

Failed tests: 
  TestTajoCli.testHelpSessionVars:410->assertOutputResult:103->assertOutputResult:107->assertOutputResult:125 expected:<...able size
\set SORT_[HASH_TABLE_SIZE [int value] - Sort hash table size
\set JOIN_HASH_TABLE_SIZE [int value] - Join hash table size
\set INDEX_ENABLED [true or false] - index scan enabled
\set INDEX_SELECTIVITY_THRESHOLD [real value] - the selectivity threshold for index scan
\set PARTITION_NO_RESULT_OVERWRITE_ENABLED [true or false] - If T]rue, a partitioned t...> but was:<...able size
\set SORT_[LIST_SIZE [int value] - List size for in-memory sort 
\set JOIN_HASH_TABLE_SIZE [int value] - Join hash table size
\set INDEX_ENABLED [true or false] - index scan enabled
\set INDEX_SELECTIVITY_THRESHOLD [real value] - the selectivity threshold for index scan
\set PARTITION_NO_RESULT_OVERWRITE_ENABLED [true or false] - If t]rue, a partitioned t...>
Tests run: 1593, Failures: 1, Errors: 0, Skipped: 0

@jihoonson
Copy link
Contributor Author

@eminency and @hyunsik, thank you guys for your review!
I fixed the test failure.

@hyunsik
Copy link
Member

hyunsik commented Nov 9, 2015

+1
The patch looks good to me.

@asfgit asfgit closed this in 254c923 Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants