This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-2021: Some refactoring and changing anonymous class to lambda expression#911
Closed
eminency wants to merge 7 commits intoapache:masterfrom
Closed
TAJO-2021: Some refactoring and changing anonymous class to lambda expression#911eminency wants to merge 7 commits intoapache:masterfrom
eminency wants to merge 7 commits intoapache:masterfrom
Conversation
* master: TAJO-1990: Refine some parts in HBaseTablespace. (fixed missed change)
Member
There was a problem hiding this comment.
This line is over 120 char
https://cwiki.apache.org/confluence/display/TAJO/Code+Style
Member
|
Looks good to me but lambda expression does not support on jdk7 |
Contributor
Author
|
@jinossy Thanks for the review. I wrapped up the lines. |
Member
|
+1 LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's some simplified code changes