TAJO-2036: Prevent out of memory in the master server, if the query result is large#928
TAJO-2036: Prevent out of memory in the master server, if the query result is large#928combineads wants to merge 5 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
numOfRows = (long)((float)(resultRows) * ((float)sizeLimit / (float) resultRows)); on the 506 line looks not necessary. Would you remove it, too?
|
@jihoonson Anything else to commit this PR? |
|
@combineads, sorry for late response. |
|
Hi @jihoonson . |
There was a problem hiding this comment.
limitRow also needs to be added to returnValue.
There was a problem hiding this comment.
Oh, my mistake. Never mind.
|
Hi @jihoonson . |
|
+1 LGTM. This patch does not relate to unit tests. |
This problem will occur frequently in our production server.
Please confirm.