TAJO-985: Client API should be non-blocking#99
TAJO-985: Client API should be non-blocking#99jinossy wants to merge 10 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
The line is longer than 120 columns.
|
Thank you for the review. I reflected your comments. |
There was a problem hiding this comment.
I think that the variable name async should be nonblocking.
|
The main idea looks good to me. It will mitigate lock contention problem. I have one suggestion. How about changing getState(boolean) and getState signatures into different names? Since the uses of them may be sensitive, we need to know what we invoke more apparently. I would like to suggest getSynchronizedState() and getState(). It's just a suggestion. The decision is up to you. |
|
@hyunsik good idea. |
…into TAJO-985 Conflicts: tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
|
I’ve reflects your suggestion. |
|
+1 The patch looks nice to me. Ship it. |
|
The word 'async' was changed during the review. So, I think that the issue title also should be changed to proper name. Could you change the title before committing? |
jinossy
changed the title
|
Thank you for the review. |
ZEPPELIN-154 scroll to focus
2 participants
The query status synchronization on state machine always wait for time (event processing time) before status changes. If a lot of time are being processed to the event dispatcher, client api(getStatus, getProgress) will be waiting for changed event status. and query will be session timed out.