Skip to content

Verbose license-binary check failures in CI #5056

@Ma77Ball

Description

@Ma77Ball

Feature Summary

When the license-binary check fails in CI, the log lists only package names and versions. Maintainers have to look up two things by hand for each offender: the package's declared license, and which of the 9 per-module LICENSE-binary files to edit. Both are already available in the script's input data; they just aren't printed.

Proposed Solution or Design

Enrich the failure report in bin/licensing/check_binary_deps.py so each bullet shows the license and the file to edit:

   + new-pkg@1.2.3  (license: MIT) → add to frontend/LICENSE-binary
   - gone-pkg@1.0.0 → remove from frontend/LICENSE-binary
   ~ foo: LICENSE-binary=1.0  bundled=1.1 → update in frontend/LICENSE-binary

License strings come from 3rdpartylicenses.json (npm) and pip-licenses.csv (python). The target file is determined by --license-binary when set; otherwise, a per-ecosystem default. Covers transitive deps too, since the input files list everything bundled. No CI workflow changes.

Affected Area

Other

Metadata

Metadata

Assignees

Labels

No labels
No labels
No fields configured for Feature.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions