Skip to content

fix(helm-chart): replace regex with wildcard in the ingress rules#4011

Merged
aicam merged 2 commits intoapache:mainfrom
aicam:fix-alb-regex
Oct 29, 2025
Merged

fix(helm-chart): replace regex with wildcard in the ingress rules#4011
aicam merged 2 commits intoapache:mainfrom
aicam:fix-alb-regex

Conversation

@aicam
Copy link
Contributor

@aicam aicam commented Oct 28, 2025

What changes were proposed in this PR?

To deploy Texera on AWS, we need to use ALB instead of Nginx. ALB currently does not support regex in the paths and only support wildcards. This PR modifies our Kubernetes Ingress resource definitions, replacing regex-based path matching with wildcard (*) matching. [AWS ALB Annotations]

Any related issues, documentation, discussions?

It has not been filed as issue since it only affect AWS deployments, however, the previous PR regarding Ingress ClassName shows our need to be able to switch Nginx with other proxifiers for different deployments.

How was this PR tested?

Ran Kubernetes locally, and also in bootcamp at the beginning of the summer we did this and worked fine.

@aicam aicam requested a review from bobbai00 October 28, 2025 22:55
@aicam aicam self-assigned this Oct 28, 2025
Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add more details to the PR description. Also I think the PR description didn't follow the PR template, can you double check and fix it? Thanks

@bobbai00 bobbai00 changed the title fix(ingress-paths): replace regex with wildcard fix(helm-chart): replace regex with wildcard in the ingress rules Oct 29, 2025
@chenlica
Copy link
Contributor

@aicam Please use the latest PR template and add more details in the description. Currently it's too high level and vague.

@chenlica chenlica self-requested a review October 29, 2025 18:32
@aicam
Copy link
Contributor Author

aicam commented Oct 29, 2025

@bobbai00 @chenlica description updated

@aicam aicam enabled auto-merge (squash) October 29, 2025 20:59
@aicam aicam merged commit 3ff3c54 into apache:main Oct 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants