fix(helm-chart): replace regex with wildcard in the ingress rules#4011
Merged
aicam merged 2 commits intoapache:mainfrom Oct 29, 2025
Merged
fix(helm-chart): replace regex with wildcard in the ingress rules#4011aicam merged 2 commits intoapache:mainfrom
aicam merged 2 commits intoapache:mainfrom
Conversation
bobbai00
approved these changes
Oct 29, 2025
Contributor
bobbai00
left a comment
There was a problem hiding this comment.
LGTM! Please add more details to the PR description. Also I think the PR description didn't follow the PR template, can you double check and fix it? Thanks
Contributor
|
@aicam Please use the latest PR template and add more details in the description. Currently it's too high level and vague. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
To deploy Texera on AWS, we need to use ALB instead of Nginx. ALB currently does not support regex in the paths and only support wildcards. This PR modifies our Kubernetes Ingress resource definitions, replacing regex-based path matching with wildcard (*) matching. [AWS ALB Annotations]
Any related issues, documentation, discussions?
It has not been filed as issue since it only affect AWS deployments, however, the previous PR regarding Ingress ClassName shows our need to be able to switch Nginx with other proxifiers for different deployments.
How was this PR tested?
Ran Kubernetes locally, and also in bootcamp at the beginning of the summer we did this and worked fine.