Skip to content

fix: regenerate protobuf files in the python#4336

Merged
aglinxinyuan merged 15 commits intomainfrom
xinyuan-fix-protoc-python
Apr 2, 2026
Merged

fix: regenerate protobuf files in the python#4336
aglinxinyuan merged 15 commits intomainfrom
xinyuan-fix-protoc-python

Conversation

@aglinxinyuan
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Regenerate protobuf files in Python.

Any related issues, documentation, discussions?

Closes #4335

How was this PR tested?

Tested manually and covered by the python test cases.

Was this PR authored or co-authored using generative AI tooling?

No.

@aglinxinyuan aglinxinyuan self-assigned this Mar 29, 2026
Copilot AI review requested due to automatic review settings March 29, 2026 05:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR regenerates the Python betterproto-generated protobuf modules so the Python side matches the current .proto definitions (addressing outdated generated code reported in #4335).

Changes:

  • Regenerated Python protobuf modules (import formatting updates in generated __init__.py files).
  • Synced RPC protobuf definitions by adding StatisticsUpdateTarget and the new update_target field on QueryStatisticsRequest.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
amber/src/main/python/proto/org/apache/texera/amber/engine/architecture/worker/init.py Generated code refresh (typing import formatting).
amber/src/main/python/proto/org/apache/texera/amber/engine/architecture/sendsemantics/init.py Generated code refresh (typing import formatting).
amber/src/main/python/proto/org/apache/texera/amber/engine/architecture/rpc/init.py Updates generated RPC module to include StatisticsUpdateTarget and QueryStatisticsRequest.update_target.
amber/src/main/python/proto/org/apache/texera/amber/core/init.py Generated code refresh (typing import formatting).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenlica
Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Please review it.

Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from xinyuan-fix-protoc-frontend to main March 31, 2026 23:37
@github-actions github-actions bot removed the common label Apr 1, 2026
@aglinxinyuan aglinxinyuan enabled auto-merge (squash) April 2, 2026 00:06
@aglinxinyuan aglinxinyuan merged commit 8cd5a56 into main Apr 2, 2026
11 checks passed
@aglinxinyuan aglinxinyuan deleted the xinyuan-fix-protoc-python branch April 2, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated protobuf files are outdated on the python

4 participants