chore(build): add customized LICENSE to jar META-INF and dist zips#4367
Merged
Conversation
Modeled after Apache Pekko's AddMetaInfLicenseFiles pattern: - Add legal/ with hand-curated StandardLicense.txt and TexeraNotice.txt - Add project/AddMetaInfLicenseFiles.scala to copy them into META-INF - Wire asfDistLicensingSettings into all 6 dist-producing modules so LICENSE/NOTICE/DISCLAIMER-WIP appear at dist zip top level Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
dependencies
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
@bobbai00 Please suggest a committer to review this PR. |
The dist zip now includes LICENSE/NOTICE/DISCLAIMER-WIP at its top level via asfDistLicensingSettings, so the manual COPY workaround in Dockerfiles is no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobbai00
changed the title
Contributor
Author
Can @aglinxinyuan review it? |
…SCLAIMER Each jar's META-INF/LICENSE now describes only what is in that specific jar rather than copying the entire source release LICENSE: - workflow-operator: Apache 2.0 + mbknor-jackson-jsonschema (MIT) - all other modules: Apache 2.0 only Rename DISCLAIMER-WIP to DISCLAIMER since the known licensing gap (missing LICENSE/NOTICE in binary artifacts) is now resolved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobbai00
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements per-module ASF licensing compliance by generating tailored META-INF licensing files for JARs and ensuring distribution ZIPs include top-level LICENSE/NOTICE/DISCLAIMER, addressing #4131.
Changes:
- Added an sbt build helper to generate per-module
META-INF/LICENSE(Apache-only vs. workflow-operator + MIT attribution) and copyNOTICE/DISCLAIMER. - Updated build configuration to apply the new per-module licensing settings and add top-level licensing files to dist ZIPs.
- Renamed/replaced
DISCLAIMER-WIPusage withDISCLAIMERacross Dockerfiles and tooling configuration.
Reviewed changes
Copilot reviewed 3 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| project/AddMetaInfLicenseFiles.scala | New sbt helper that generates/copies licensing files for JAR META-INF and dist ZIPs. |
| DISCLAIMER | Removes WIP compliance note now that the artifacts are being updated. |
| build.sbt | Switches from generic copy to per-module licensing settings; applies dist ZIP licensing mappings to service modules. |
| bin/*.dockerfile | Updates Docker builds to use DISCLAIMER (and removes redundant runtime-stage copying). |
| .licenserc.yaml | Removes DISCLAIMER-WIP from license header configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aglinxinyuan
approved these changes
Apr 13, 2026
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
The PR looks good to me.
The DISCLAIMER now says we are fully compliant with the ASF policy. It's a very strong claim. I don't see any place that isn't following the ASF policy, but it's better to have a second eye on this before the next RC.
Contributor
|
@bobbai00 please ask Ian Maxon to review it. |
bobbai00
changed the title
- Replace magic number idx>=200 with search for THIRD-PARTY DEPENDENCIES header - Remove duplicate DISCLAIMER entry in reserved set Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Per apache#4372, the WIP disclaimer should stay until Docker image LICENSE/NOTICE files properly describe their contents. Updated the known-issues bullet to reflect that jar licensing is now fixed and only Docker image licensing remains outstanding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
After viewing some ASF documents, this PR does NOT make Texera fully compliant with ASF policy. So this PR will NOT change DISCLAIMER-WIP to DISCLAIMER |
bobbai00
changed the title
bobbai00
changed the title
bobbai00
added a commit
to bobbai00/texera
that referenced
this pull request
Apr 18, 2026
…pache#4367) ### What changes were proposed in this PR? This PR ensures that: - Each jar's `LICENSE` describes only what is in that jar - For `workflow-operator` jar: the LICENSE includes Apache 2.0 and 3rd party code `mbknor-jackson-jsonschema` MIT attribution and MIT license. - All other jars: the LICENSE is Apache 2.0 only - the zips produced by `sbt dist` include LICENSE/NOTICE/DISCLAIMER at the top level ### Any related issues, documentation, discussions? Closes apache#4394 ### How was this PR tested? - Built dist zips and inspected jar META-INF/LICENSE content - Verified all Texera module jars are thin jars (no dependency classes merged in) - Confirmed `workflow-operator` is the only jar with non-Apache classes (`com/kjetland`) ### Was this PR authored or co-authored using generative AI tooling? Co-authored using: Claude Code (Claude Opus 4.6) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR ensures that:
LICENSEdescribes only what is in that jarworkflow-operatorjar: the LICENSE includes Apache 2.0 and 3rd party codembknor-jackson-jsonschemaMIT attribution and MIT license.sbt distinclude LICENSE/NOTICE/DISCLAIMER at the top levelAny related issues, documentation, discussions?
Closes #4394
How was this PR tested?
workflow-operatoris the only jar with non-Apache classes (com/kjetland)Was this PR authored or co-authored using generative AI tooling?
Co-authored using: Claude Code (Claude Opus 4.6)