fix: old workflows failing to run after input port field rename#4379
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a frontend backward-compatibility shim to allow executing older saved workflows whose port JSON still contains the legacy allowMultiInputs field, by stripping that legacy field from the logical plan payload sent to the backend.
Changes:
- Sanitize operator
inputPortsinExecuteWorkflowService.getLogicalPlanRequestto removeallowMultiInputsbefore sending the plan to the backend.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
…he#4379) ### What changes were proposed in this PR? This PR adds a backward-compatibility fix for older saved workflows that still contain the legacy allowMultiInputs field in serialized input port definitions. After the input port model was changed to use disallowMultiInputs, older workflow JSON in the database could no longer be deserialized correctly and workflow execution failed with an UnrecognizedPropertyException. This PR updates backend deserialization for PortDescription to ignore the obsolete allowMultiInputs field so those existing workflows can still run without requiring migration or manual cleanup. We can remove this change later. ### Any related issues, documentation, discussions? Closes apache#4378 ### How was this PR tested? Tested with the workflow generated by an older version of Texera (before PR apache#4342). ### Was this PR authored or co-authored using generative AI tooling? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds a backward-compatibility fix for older saved workflows that still contain the legacy allowMultiInputs field in serialized input port definitions.
After the input port model was changed to use disallowMultiInputs, older workflow JSON in the database could no longer be deserialized correctly and workflow execution failed with an UnrecognizedPropertyException. This PR updates backend deserialization for PortDescription to ignore the obsolete allowMultiInputs field so those existing workflows can still run without requiring migration or manual cleanup.
We can remove this change later.
Any related issues, documentation, discussions?
Closes #4378
How was this PR tested?
Tested with the workflow generated by an older version of Texera (before PR #4342).
Was this PR authored or co-authored using generative AI tooling?
No.