refactor: move text selection handling to workspace component#4383
Merged
Conversation
github-actions
Bot
added
refactor
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR refactors the text selection behavior by moving the non-selectable handling to the workspace component. The overall effect is similar to the current version, with a few additional workflow-related areas also becoming non-selectable. The Layers dropdown remains handled separately, since it is not part of the workspace component's :host DOM subtree.
Demonstration:
Any related issues, documentation, discussions?
Related PR: #4366
Related issue: #4365
How was this PR tested?
Tested manually
Was this PR authored or co-authored using generative AI tooling?
No