chore(deps): upgrade frontend to Angular 18#4434
Merged
Merged
Conversation
github-actions
Bot
added
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the frontend to Angular 18 to address #4405, updating framework/tooling dependencies and making small compatibility fixes in templates and unit tests.
Changes:
- Bump Angular framework packages to
18.2.xand Angular CLI/build tooling to18.2.21(plus related ecosystem upgrades like TypeScript and ng-zorro). - Update ng-zorro collapse icon position API usage (
right→end) for ng-zorro 18 compatibility. - Replace deprecated/removed Angular testing helper
asyncwithwaitForAsyncin a unit test.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/workspace/component/result-panel/result-panel.component.spec.ts | Updates Angular testing helper to waitForAsync for Angular 18 compatibility. |
| frontend/src/app/workspace/component/left-panel/operator-menu/operator-menu.component.html | Updates nzExpandIconPosition value to match ng-zorro 18 API. |
| frontend/package.json | Upgrades Angular + related frontend dependencies/tooling (CLI/devkit/eslint/typescript/ng-zorro/ngx-markdown). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mengw15
approved these changes
Apr 22, 2026
Contributor
mengw15
left a comment
mengw15
left a comment
There was a problem hiding this comment.
LGTM!
Tested with yarn install, yarn build, and yarn test.
I also checked the frontend and did not notice any obvious issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
18.2.x.18.2.21.@angular/cdkto18.2.14ng-zorro-antdto18.2.1ngx-markdownto18.1.0typescriptto5.5.4@typescript-eslintpeer dependencies for Angular ESLint 18.nzExpandIconPosition="right"tonzExpandIconPosition="end"for ng-zorro 18 compatibility.asyncwithwaitForAsync.Any related issues, documentation, discussions?
Closes #4405
How was this PR tested?
yarn.cmd installyarn.cmd buildyarn.cmd test --watch=falseWas this PR authored or co-authored using generative AI tooling?
Generated-by: Codex