Skip to content

chore(deps): upgrade frontend to Angular 19#4445

Merged
aglinxinyuan merged 34 commits into
mainfrom
xinyuan-angular-19
Apr 27, 2026
Merged

chore(deps): upgrade frontend to Angular 19#4445
aglinxinyuan merged 34 commits into
mainfrom
xinyuan-angular-19

Conversation

@aglinxinyuan
Copy link
Copy Markdown
Contributor

@aglinxinyuan aglinxinyuan commented Apr 22, 2026

What changes were proposed in this PR?

  • Upgraded Angular framework packages to 19.2.x.
  • Upgraded Angular CLI/devkit tooling to 19.2.24.
  • Upgraded Node to 20.19.0.
  • Upgraded compatible frontend dependencies:
    • @angular/cdk to 19.2.19
    • ng-zorro-antd to 19.3.1
    • ngx-markdown to 19.1.1
    • marked to 15.0.12
    • zone.js to 0.15.1
    • @nx/angular / nx to 21.6.11
    • @typescript-eslint/* to 8.59.0
  • Ran Angular’s explicit-standalone-flag migration to preserve existing NgModule declarations under Angular 19.
  • Updated Angular dev-server config from browserTarget to buildTarget.
  • Updated yarn build to use an 8 GB Node heap, matching the existing CI build memory behavior.
  • Kept typescript pinned at 5.5.4 to avoid deep type-instantiation errors seen with 5.8.x.

Any related issues, documentation, discussions?

Closes #4431.

How was this PR tested?

  • yarn.cmd install
  • yarn.cmd build
  • yarn.cmd build:ci
  • yarn.cmd test --watch=false
  • yarn.cmd ng serve

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Codex

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI labels Apr 22, 2026
@aglinxinyuan aglinxinyuan requested a review from mengw15 April 22, 2026 07:08
@aglinxinyuan aglinxinyuan self-assigned this Apr 22, 2026
@aglinxinyuan aglinxinyuan changed the title chore(deps): upgrade frontend to Angular 18 chore(deps): upgrade frontend to Angular 19 Apr 22, 2026
@github-actions github-actions Bot added the ci changes related to CI label Apr 22, 2026
@aglinxinyuan aglinxinyuan removed the request for review from mengw15 April 22, 2026 15:48
@chenlica
Copy link
Copy Markdown
Contributor

@zuozhiw @Xiao-zhen-Liu Can you review this PR?

@github-actions github-actions Bot removed the ci changes related to CI label Apr 22, 2026
@github-actions github-actions Bot added the ci changes related to CI label Apr 23, 2026
Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and no major issues seen. But there are a few compatibility issues I see.

Comment thread frontend/package.json
Comment thread frontend/package.json Outdated
@aglinxinyuan
Copy link
Copy Markdown
Contributor Author

@Xiao-zhen-Liu comments addressed, please review again.

@aglinxinyuan
Copy link
Copy Markdown
Contributor Author

@Yicong-Huang, do you know how to remove the old CIs? I bumped node from 18 to 20, but the CI for node 18 is still pending.

Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aglinxinyuan aglinxinyuan merged commit 1ce60d6 into main Apr 27, 2026
11 checks passed
@aglinxinyuan aglinxinyuan deleted the xinyuan-angular-19 branch April 27, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 19

3 participants