perf(amber): reuse spec ActorSystem in CheckpointSpec#4502
Closed
Yicong-Huang wants to merge 1 commit into
Closed
Conversation
CheckpointSpec was the slowest spec in CI (~70s) because it booted two ActorSystems: one in beforeAll and a second one lazily inside AmberRuntime.serde when chkpt.save was first called. The two systems never interacted — the second was only created so SerializationExtension had a system to attach to. Add an actorSystem setter on AmberRuntime so the spec can hand its own system to the runtime; the lazy fallback no longer fires. Also drop long-stale commented-out tests in CheckpointSpec. Closes apache#4501
Yicong-Huang
force-pushed
the
perf/checkpoint-spec-runtime
branch
from
df7b2ed to
d494180
Compare
Contributor
Author
|
Closing — analysis methodology was wrong. ScalaTest emits the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
CheckpointSpecwas the slowest spec in CI (~70s for 2 trivial assertions) because it booted two PekkoActorSystems:beforeAll(CheckpointSpec.scala:62)AmberRuntime.serdewhenchkpt.save(...)was first calledThe two systems never interacted — the second only existed so
SerializationExtensionhad a system to attach to.This PR adds an
actorSystem_=setter onAmberRuntimeand uses it inCheckpointSpec.beforeAllto hand the spec's own system to the runtime, so the lazy fallback never fires.Any related issues, documentation, discussions?
Closes #4501
How was this PR tested?
Existing
CheckpointSpectests cover the two assertions. Verified locally that the spec still completes the same two assertions; relying on CI to confirm full timing improvement.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)