chore(amber): remove unused SchedulerTimeSlotExpiredPause#4533
Merged
Yicong-Huang merged 3 commits intoApr 27, 2026
Merged
Conversation
Drop the SchedulerTimeSlotExpiredPause pause type and the associated dead handler, neither of which is referenced anywhere in the codebase. Closes apache#4532 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zuozhiw
approved these changes
Apr 27, 2026
Contributor
zuozhiw
left a comment
zuozhiw
left a comment
There was a problem hiding this comment.
looks good thx for the cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Remove the unused
SchedulerTimeSlotExpiredPausepause type and the dead Python handler that referenced it. None of the following symbols are referenced anywhere in the codebase:SchedulerTimeSlotExpiredPause(Scala) inamber/src/main/scala/.../worker/PauseType.scalaPauseType.SCHEDULER_TIME_SLOT_EXPIRED_PAUSE(Python) inamber/src/main/python/core/architecture/managers/pause_manager.pyMainLoop._scheduler_time_slot_event(Python) inamber/src/main/python/core/runnables/main_loop.py— never calledThe Python enum is renumbered to keep values consecutive; the int values are not serialized externally.
Any related issues, documentation, discussions?
Closes #4532
How was this PR tested?
Pure dead-code removal — no behavior change. Verified via repo-wide grep that no references to the removed symbols remain. Existing
sbt testand Python tests cover the surrounding pause/main-loop code paths.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)