Skip to content

fix(frontend): version history timestamp display#4539

Merged
aglinxinyuan merged 2 commits into
mainfrom
xinyuan-fix-timestamp
Apr 28, 2026
Merged

fix(frontend): version history timestamp display#4539
aglinxinyuan merged 2 commits into
mainfrom
xinyuan-fix-timestamp

Conversation

@aglinxinyuan
Copy link
Copy Markdown
Contributor

@aglinxinyuan aglinxinyuan commented Apr 28, 2026

What changes were proposed in this PR?

  • update the version history timestamp format from YY to yy
  • use Angular’s calendar-year token so timestamps render correctly in the frontend
  • yy is Angular’s calendar-year token for a 2-digit year, while YY is the ISO week-numbering year token.

Any related issues, documentation, discussions?

Closes #4538

How was this PR tested?

Tested with test case.

Was this PR authored or co-authored using generative AI tooling?

No.

@aglinxinyuan aglinxinyuan self-assigned this Apr 28, 2026
@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Apr 28, 2026
@aglinxinyuan aglinxinyuan changed the title init fix: version history timestamp display Apr 28, 2026
Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xiao-zhen-Liu Xiao-zhen-Liu changed the title fix: version history timestamp display fix(frontend): version history timestamp display Apr 28, 2026
@aglinxinyuan aglinxinyuan merged commit a38f0ec into main Apr 28, 2026
33 of 37 checks passed
@aglinxinyuan aglinxinyuan deleted the xinyuan-fix-timestamp branch April 28, 2026 02:35
@chenlica
Copy link
Copy Markdown
Contributor

Just curious: how is "yy" different from "YY"? Can we add a description in the PR?

@aglinxinyuan
Copy link
Copy Markdown
Contributor Author

"yy" is the correct one, and "YY" is the incorrect one. yy is Angular’s calendar-year token for a 2-digit year, while YY is the ISO week-numbering year token. Before Angular 21, they didn't enforce this.

Source: https://angular.dev/api/common/DatePipe

@chenlica
Copy link
Copy Markdown
Contributor

Thanks. I am surprised their design is case sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timestamp not showing up correctly on the frontend

3 participants