chore: drop -WIP suffix from DISCLAIMER#4555
Merged
Merged
Conversation
The binary-license bundling work (apache#4387, apache#4449) resolved the WIP-blocking compliance gap, so rename DISCLAIMER-WIP to DISCLAIMER, drop the "currently aware of" issues paragraph, and update all references in dockerfiles, build.sbt files, the license-header skiplist, and AddMetaInfLicenseFiles.scala.
github-actions
Bot
added
engine
dependencies
Contributor
Author
|
Dear @pjfanning , can you review this PR? |
Member
|
@bobbai00 I am a mentor on the project, not a project member per se. It is my view that I am here to provide high level guidance and not to do direct code reviews. I think it is up to the team to spread the knowledge about the license requirements and the ASF and ASF Incubator rules. That is not helped if I do the reviews. |
Contributor
Author
Got it. I will have team members to review this one. During the process of preparing for the LICENSE-binary, I believe the team has a deeper understanding of the ASF rules. |
Contributor
Author
|
Can @aglinxinyuan and @Xiao-zhen-Liu review this? |
bobbai00
added
release/v1.1.0-incubating
github-actions Bot
pushed a commit
that referenced
this pull request
May 2, 2026
(backported from commit ab70008)
SarahAsad23
pushed a commit
to SarahAsad23/texera
that referenced
this pull request
May 4, 2026
This was referenced May 4, 2026
bobbai00
added a commit
that referenced
this pull request
May 4, 2026
…4927) ### What changes were proposed in this PR? Drop the non-canonical second paragraph (licensing-review caveat + incubator status URL) from `DISCLAIMER` and its verbatim copy at `bin/single-node/DISCLAIMER`. Only the first paragraph is part of the standard ASF Incubator disclaimer template. The trimmed file flows automatically into JAR `META-INF/` entries and all Docker images via existing sbt + Dockerfile copy steps — no other code changes needed. Follow-up to the disclaimer/licensing cleanup in 47bb2e4 / #4288 (and rename in #4555), which left this section untrimmed. ### Any related issues, documentation, discussions? Closes #4926. Related: #4288, #4555. ### How was this PR tested? Text-only change to release artifacts metadata. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.7)
Yicong-Huang
pushed a commit
that referenced
this pull request
May 4, 2026
…4927) ### What changes were proposed in this PR? Drop the non-canonical second paragraph (licensing-review caveat + incubator status URL) from `DISCLAIMER` and its verbatim copy at `bin/single-node/DISCLAIMER`. Only the first paragraph is part of the standard ASF Incubator disclaimer template. The trimmed file flows automatically into JAR `META-INF/` entries and all Docker images via existing sbt + Dockerfile copy steps — no other code changes needed. Follow-up to the disclaimer/licensing cleanup in 47bb2e4 / #4288 (and rename in #4555), which left this section untrimmed. ### Any related issues, documentation, discussions? Closes #4926. Related: #4288, #4555. ### How was this PR tested? Text-only change to release artifacts metadata. ### Was this PR authored or co-authored using generative AI tooling? (backported from commit 265e0f8) Generated-by: Claude Code (Opus 4.7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR drops the -WIP suffix from DISCLAIMER, along with the WIP content. The binary-license bundling work (#4387, #4449) resolved the blockers for compliance. This PR also updates all
DISCLAIMER-WIPreferences in dockerfiles, build.sbt files, the license-header skiplist, and AddMetaInfLicenseFiles.scala.Any related issues, documentation, discussions?
Closes #4131
Closes #4371
Closes #4372
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude code