test(amber): add unit test coverage for WorkflowScheduler#4564
Merged
aglinxinyuan merged 2 commits intoapache:mainfrom Apr 30, 2026
Merged
test(amber): add unit test coverage for WorkflowScheduler#4564aglinxinyuan merged 2 commits intoapache:mainfrom
aglinxinyuan merged 2 commits intoapache:mainfrom
Conversation
### What changes were proposed in this PR? Add `WorkflowSchedulerSpec` covering the public contract of `WorkflowScheduler`: - `updateSchedule` populates `getSchedule` and `physicalPlan` from the input workflow - The produced schedule covers every operator in the (post-update) physical plan - `getNextRegions` exhausts the schedule and then returns an empty set - The union of region sets pulled via `getNextRegions` matches `getSchedule.getRegions` ### Any related issues, documentation, discussions? Closes apache#4563 ### How was this PR tested? `sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.controller.WorkflowSchedulerSpec"` — 4/4 tests pass. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Yicong-Huang
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add
WorkflowSchedulerSpeccovering the public contract ofWorkflowScheduler(amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala):updateSchedulepopulatesgetScheduleandphysicalPlanfrom the input workflowgetNextRegionsexhausts the schedule and then returns an empty setgetNextRegionsmatchesgetSchedule.getRegionsAny related issues, documentation, discussions?
Closes #4563
How was this PR tested?
sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.controller.WorkflowSchedulerSpec"— 4/4 tests pass.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)