test(amber): add unit test coverage for Region#4568
Merged
Conversation
### What changes were proposed in this PR? Add `RegionSpec` covering the public surface of `Region`: - Constructor exposes `physicalOps`, `physicalLinks`, and `ports` via `getOperators`/`getLinks`/`getPorts` - `getOperator(id)` looks up by `PhysicalOpIdentity` and throws `NoSuchElementException` for unknown ids - `topologicalIterator` yields operators in topological order derived from `physicalLinks` - `getSourceOperators` treats operators without input ports as sources - `getStarterOperators` equals `getSourceOperators` when no `resourceConfig` is provided ### Any related issues, documentation, discussions? Closes apache#4567 ### How was this PR tested? `sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.scheduling.RegionSpec"` — 9/9 tests pass. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Yicong-Huang
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add
RegionSpeccovering the public surface ofRegion(amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/Region.scala):physicalOps,physicalLinks, andportsviagetOperators/getLinks/getPortsgetOperator(id)looks up byPhysicalOpIdentityand throwsNoSuchElementExceptionfor unknown idstopologicalIteratoryields operators in topological order derived fromphysicalLinksgetSourceOperatorstreats operators without input ports as sourcesgetStarterOperatorsequalsgetSourceOperatorswhen noresourceConfigis providedAny related issues, documentation, discussions?
Closes #4567
How was this PR tested?
sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.scheduling.RegionSpec"— 9/9 tests pass.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)