test(amber): add unit test coverage for WorkflowExecution#4572
Merged
aglinxinyuan merged 2 commits intoMay 1, 2026
Merged
Conversation
### What changes were proposed in this PR? Add `WorkflowExecutionSpec` covering the lifecycle and lookup contract of `WorkflowExecution`: - `initRegionExecution` creates a new `RegionExecution`; throws on re-init for the same region id - `hasRegionExecution` reflects init state - `getRegionExecution` throws `NoSuchElementException` for unknown ids - `getAllRegionExecutions` preserves insertion order (LinkedHashMap) - `restartRegionExecution` behaves like a fresh init when no prior region exists, and replaces a completed region with a fresh execution - `getRunningRegionExecutions` excludes completed regions - `getState` returns UNINITIALIZED on empty and COMPLETED when every initialized region is completed - `getLatestOperatorExecutionOption` returns None when none exists and the latest match across regions otherwise (uses reference identity because `OperatorExecution` is a no-field case class) ### Any related issues, documentation, discussions? Closes apache#4571 ### How was this PR tested? `sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.controller.execution.WorkflowExecutionSpec"` — 12/12 tests pass. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Yicong-Huang
approved these changes
Apr 30, 2026
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM! Thanks. Tests look good, but I identified many todos in source code. That's why we needed those test cases!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add
WorkflowExecutionSpeccovering the lifecycle and lookup contract ofWorkflowExecution(amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/execution/WorkflowExecution.scala):initRegionExecutioncreates a newRegionExecution; throws on re-init for the same region idhasRegionExecutionreflects init stategetRegionExecutionthrowsNoSuchElementExceptionfor unknown idsgetAllRegionExecutionspreserves insertion order (LinkedHashMap)restartRegionExecutionbehaves like a fresh init when no prior region exists, and replaces a completed region with a fresh executiongetRunningRegionExecutionsexcludes completed regionsgetStatereturns UNINITIALIZED on empty and COMPLETED when every initialized region is completedgetLatestOperatorExecutionOptionreturns None when none exists and the latest match across regions otherwise (uses reference identity becauseOperatorExecutionis a no-field case class)Any related issues, documentation, discussions?
Closes #4571
How was this PR tested?
sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.controller.execution.WorkflowExecutionSpec"— 12/12 tests pass.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)