Skip to content

fix(frontend): adjust dataset detail page's alignment and padding#4584

Merged
bobbai00 merged 2 commits into
apache:mainfrom
xuang7:fix/dataset-detail-ui-alignment
Apr 30, 2026
Merged

fix(frontend): adjust dataset detail page's alignment and padding#4584
bobbai00 merged 2 commits into
apache:mainfrom
xuang7:fix/dataset-detail-ui-alignment

Conversation

@xuang7
Copy link
Copy Markdown
Contributor

@xuang7 xuang7 commented Apr 30, 2026

What changes were proposed in this PR?

This PR fixes some UI alignment issues on the dataset detail page:

  • status tag icons not being centered within their colored background boxes.
  • redundant margins on the file preview area.
  • vertical misalignment between the version selector and the download button.
  • unnecessary left padding on the version storage section.
  • redundant margins on upload progress containers.

Current layout (extra padding on file preview):
Screenshot 2026-04-30 at 10 02 32 AM

New layout:

Screenshot 2026-04-30 at 12 37 18 PM

New version section:

current updated

Any related issues, documentation, discussions?

Resolves #4583

How was this PR tested?

Manually tested

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 4.7

@github-actions github-actions Bot added fix frontend Changes related to the frontend GUI labels Apr 30, 2026
@xuang7
Copy link
Copy Markdown
Contributor Author

xuang7 commented Apr 30, 2026

This PR is a small layout fix. It would be good if it could be included in the release. No functionality changes, so it's safe to include or skip. Could you help review? Thanks! @bobbai00

@bobbai00 bobbai00 changed the title fix: dataset detail page alignment and padding issues fix(frontend): dataset detail page alignment and padding issues Apr 30, 2026
@bobbai00 bobbai00 changed the title fix(frontend): dataset detail page alignment and padding issues fix(frontend): adjust dataset detail page's alignment and padding Apr 30, 2026
@bobbai00 bobbai00 enabled auto-merge (squash) April 30, 2026 22:18
@bobbai00 bobbai00 self-requested a review April 30, 2026 22:18
Copy link
Copy Markdown
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbai00
Copy link
Copy Markdown
Contributor

@xuang7 can you raise another PR that backport this change to the branch release/v1-1-0-incubating and assign me as the reviewer?

@aglinxinyuan
Copy link
Copy Markdown
Contributor

aglinxinyuan commented Apr 30, 2026

Do we want to merge this PR into the release branch and merge the release branch into main after the release? (without deleting the release branch)

@Yicong-Huang, what do you think? Any other way to avoid duplicate PRs?

This comment is not blocking. Feel free to raise another PR that backports this change.

@bobbai00 bobbai00 merged commit 2920b0c into apache:main Apr 30, 2026
19 checks passed
@Yicong-Huang
Copy link
Copy Markdown
Contributor

@Yicong-Huang, what do you think? Any other way to avoid duplicate PRs?

see #4580 I am building up a CI to use a backport label on PR to automatically merge both into main and the target release branch. If the label is added, CIs against the target release PR will ideally be run on the PR. stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dataset page layout issue: icon misaligned and some extra padding

4 participants