fix(hub-frontend): display public datasets/workflows on hub page#4587
Merged
bobbai00 merged 2 commits intoMay 1, 2026
Conversation
Contributor
Author
|
This is backport PR for release/v1-1-0-incubating, thanks. @bobbai00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes an issue where public datasets/workflows fail to display on the hub search result page on first render. After the Angular upgrade,
@ViewChildisundefinedduring the first render, and the previous getters forfiltersandsearchResultsComponentthrew an error in that case.Changes:
filtersandsearchResultsComponentgetters to returnundefinedwhen the child view is not yet initialized.search()to skip until both are ready.searchKeywordsinto a component property so the template no longer dereferencesfilterswhile it'sundefined.Any related issues, documentation, discussions?
Resolves #4578
Backport to the 1.1 release branch.
How was this PR tested?
Manually tested
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7