Skip to content

fix(ci): treat skipped backport jobs as green in Direct Backport Push#4629

Merged
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/backport-discovery-treat-skipped
May 2, 2026
Merged

fix(ci): treat skipped backport jobs as green in Direct Backport Push#4629
Yicong-Huang merged 1 commit into
apache:mainfrom
Yicong-Huang:fix/backport-discovery-treat-skipped

Conversation

@Yicong-Huang
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

After #4622 the precheck step legitimately skips build stacks based on PR labels (e.g., a PR without the frontend label skips the frontend stack). The backport caller propagates these toggles, so the corresponding backport (target) / frontend (...) job ends with conclusion: "skipped".

direct-backport-push.yml's discovery filter required every matching job to be success, so legitimately-skipped jobs caused the whole target to be classified as not-green and push-backports was silently skipped. Match the Required Checks aggregator's logic by accepting both success and skipped.

Any related issues, documentation, discussions?

Closes #4628. Triggered by run 25237976528 for the merge of #4622.

How was this PR tested?

Single-line filter change; YAML parses locally. Will be exercised on the next merge of a PR with release/* labels and a partially-skipped build matrix.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.7)

After apache#4622 the precheck step legitimately skips build stacks based
on PR labels (e.g., a PR without the frontend label skips frontend).
The backport caller propagates these toggles, so the corresponding
backport (target) / frontend (...) job ends with conclusion=skipped.

The discovery filter required every matching job to be success, so
those legitimately-skipped jobs caused the whole target to be
classified as not-green and push-backports was silently skipped.
Match the Required Checks aggregator's logic by accepting both
success and skipped.

Closes apache#4628

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added fix ci changes related to CI labels May 2, 2026
@Yicong-Huang Yicong-Huang requested a review from aglinxinyuan May 2, 2026 00:06
@Yicong-Huang Yicong-Huang added the release/v1.1.0-incubating back porting to release/v1.1.0-incubating label May 2, 2026
@Yicong-Huang Yicong-Huang enabled auto-merge (squash) May 2, 2026 00:10
Copy link
Copy Markdown
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yicong-Huang Yicong-Huang merged commit 8e40078 into apache:main May 2, 2026
39 of 55 checks passed
github-actions Bot pushed a commit that referenced this pull request May 2, 2026
…#4629)

### What changes were proposed in this PR?

After #4622 the `precheck` step legitimately skips build stacks based on
PR labels (e.g., a PR without the `frontend` label skips the frontend
stack). The backport caller propagates these toggles, so the
corresponding `backport (target) / frontend (...)` job ends with
`conclusion: "skipped"`.

`direct-backport-push.yml`'s discovery filter required **every**
matching job to be `success`, so legitimately-skipped jobs caused the
whole target to be classified as not-green and `push-backports` was
silently skipped. Match the `Required Checks` aggregator's logic by
accepting both `success` and `skipped`.

### Any related issues, documentation, discussions?

Closes #4628. Triggered by run
[25237976528](https://github.com/apache/texera/actions/runs/25237976528)
for the merge of #4622.

### How was this PR tested?

Single-line filter change; YAML parses locally. Will be exercised on the
next merge of a PR with `release/*` labels and a partially-skipped build
matrix.

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.7)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

(backported from commit 8e40078)
SarahAsad23 pushed a commit to SarahAsad23/texera that referenced this pull request May 4, 2026
…apache#4629)

### What changes were proposed in this PR?

After apache#4622 the `precheck` step legitimately skips build stacks based on
PR labels (e.g., a PR without the `frontend` label skips the frontend
stack). The backport caller propagates these toggles, so the
corresponding `backport (target) / frontend (...)` job ends with
`conclusion: "skipped"`.

`direct-backport-push.yml`'s discovery filter required **every**
matching job to be `success`, so legitimately-skipped jobs caused the
whole target to be classified as not-green and `push-backports` was
silently skipped. Match the `Required Checks` aggregator's logic by
accepting both `success` and `skipped`.

### Any related issues, documentation, discussions?

Closes apache#4628. Triggered by run
[25237976528](https://github.com/apache/texera/actions/runs/25237976528)
for the merge of apache#4622.

### How was this PR tested?

Single-line filter change; YAML parses locally. Will be exercised on the
next merge of a PR with `release/*` labels and a partially-skipped build
matrix.

### Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 4.7)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI fix release/v1.1.0-incubating back porting to release/v1.1.0-incubating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct Backport Push wrongly skips when a backport stack is intentionally skipped

2 participants