test(pyamber): cover sendsemantics partitioners#4664
Merged
Yicong-Huang merged 3 commits intoMay 2, 2026
Conversation
Backfill unit tests for the 5 partitioners under core/architecture/sendsemantics/ — broadcast, round-robin, one-to-one, hash-based shuffle, range-based shuffle. Coverage on the module rises from 56.6% to 99% (every concrete file is 100%; the abstract Partitioner base retains pass-stub lines). Closes apache#4663. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4664 +/- ##
=======================================
Coverage ? 53.01%
Complexity ? 1993
=======================================
Files ? 817
Lines ? 24630
Branches ? 1921
=======================================
Hits ? 13057
Misses ? 10916
Partials ? 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add unit tests for the 5 concrete partitioners under
core/architecture/sendsemantics/: broadcast, round-robin, one-to-one, hash-based shuffle, and range-based shuffle.For each partitioner the suite covers the constructor,
add_tuple_to_batch,flush,flush_state, andreset. The range partitioner additionally exercisesget_receiver_indexat below-min, above-max, and in-range boundary values.Any related issues, documentation, discussions?
Closes #4663.
How was this PR tested?
```
python3 -m pytest core/architecture/sendsemantics/test_partitioners.py
```
35 tests, all passing. The file lives in the existing python test layout, so the existing python CI job picks it up with no extra setup.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7, 1M context)