Skip to content

test(amber): add unit tests for OrderingEnforcer#4721

Merged
aglinxinyuan merged 3 commits into
apache:mainfrom
Yicong-Huang:test-ordering-enforcer
May 3, 2026
Merged

test(amber): add unit tests for OrderingEnforcer#4721
aglinxinyuan merged 3 commits into
apache:mainfrom
Yicong-Huang:test-ordering-enforcer

Conversation

@Yicong-Huang
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Adds scalatest coverage for amber/src/main/scala/org/apache/texera/amber/engine/architecture/messaginglayer/OrderingEnforcer.scala. The FIFO/exactly-once helper had no dedicated spec.

Any related issues, documentation, discussions?

Closes #4720.

How was this PR tested?

sbt scalafmtCheckAll
sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.messaginglayer.OrderingEnforcerSpec"

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-4-7)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.70%. Comparing base (0c56819) to head (a106a18).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4721      +/-   ##
============================================
- Coverage     42.73%   41.70%   -1.04%     
- Complexity     2003     2015      +12     
============================================
  Files           957      978      +21     
  Lines         34077    34569     +492     
  Branches       3753     3779      +26     
============================================
- Hits          14564    14416     -148     
- Misses        18733    19373     +640     
  Partials        780      780              
Flag Coverage Δ
access-control-service ?
amber 40.57% <ø> (+0.07%) ⬆️
computing-unit-managing-service ?
config-service ?
file-service ?
python 84.10% <ø> (-0.06%) ⬇️
workflow-compiling-service ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Closes apache#4720

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Yicong-Huang Yicong-Huang force-pushed the test-ordering-enforcer branch from f2a2a10 to e63887f Compare May 3, 2026 01:00
@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 3, 2026 01:29
@aglinxinyuan aglinxinyuan disabled auto-merge May 3, 2026 01:29
@aglinxinyuan aglinxinyuan requested a review from Copilot May 3, 2026 01:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated ScalaTest spec for Amber’s OrderingEnforcer (FIFO / exactly-once helper) to improve regression protection and close the existing coverage gap noted in #4720.

Changes:

  • Introduces OrderingEnforcerSpec covering setCurrent, isDuplicated, isAhead, stash, and enforceFIFO behaviors.
  • Exercises key FIFO draining scenarios: empty stash, contiguous drain, drain-until-gap, and non-contiguous stash behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 3, 2026 01:31
@aglinxinyuan aglinxinyuan merged commit 88c7a21 into apache:main May 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for OrderingEnforcer

4 participants