test(amber): add unit tests for OrderingEnforcer#4721
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4721 +/- ##
============================================
- Coverage 42.73% 41.70% -1.04%
- Complexity 2003 2015 +12
============================================
Files 957 978 +21
Lines 34077 34569 +492
Branches 3753 3779 +26
============================================
- Hits 14564 14416 -148
- Misses 18733 19373 +640
Partials 780 780
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes apache#4720 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
f2a2a10 to
e63887f
Compare
aglinxinyuan
approved these changes
May 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated ScalaTest spec for Amber’s OrderingEnforcer (FIFO / exactly-once helper) to improve regression protection and close the existing coverage gap noted in #4720.
Changes:
- Introduces
OrderingEnforcerSpeccoveringsetCurrent,isDuplicated,isAhead,stash, andenforceFIFObehaviors. - Exercises key FIFO draining scenarios: empty stash, contiguous drain, drain-until-gap, and non-contiguous stash behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds scalatest coverage for
amber/src/main/scala/org/apache/texera/amber/engine/architecture/messaginglayer/OrderingEnforcer.scala. The FIFO/exactly-once helper had no dedicated spec.Any related issues, documentation, discussions?
Closes #4720.
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-4-7)