test(workflow-core): add unit test coverage for StorageUtil#4761
Merged
aglinxinyuan merged 2 commits intoMay 3, 2026
Conversation
Add StorageUtilSpec covering the loan-pattern wrappers withReadLock, withWriteLock, and withLock: each executes the block and returns its value, and each releases the underlying lock even when the block throws. Closes apache#4759 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ScalaTest unit coverage for StorageUtil’s loan-pattern lock wrappers in common/workflow-core, validating both normal-return behavior and lock release on exceptions (per #4759).
Changes:
- Introduces
StorageUtilSpeccoveringwithReadLock,withWriteLock, andwithLock. - Verifies each wrapper returns the block’s value.
- Verifies locks are released even when the wrapped block throws.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
=========================================
Coverage 43.43% 43.44%
- Complexity 2056 2057 +1
=========================================
Files 957 957
Lines 34077 34077
Branches 3753 3753
=========================================
+ Hits 14802 14804 +2
+ Misses 18477 18475 -2
Partials 798 798
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add
StorageUtilSpeccovering the loan-pattern wrappers inStorageUtil:withReadLock,withWriteLock, andwithLockexecute the block and return its valueAny related issues, documentation, discussions?
Closes #4759
How was this PR tested?
sbt "WorkflowCore/testOnly org.apache.texera.amber.core.storage.util.StorageUtilSpec"— 6/6 tests pass.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)