fix: Adding Floor to idle_time#4900
Merged
Merged
Conversation
Yicong-Huang
reviewed
May 4, 2026
Signed-off-by: Matthew B. <mgball@uci.edu>
Yicong-Huang
reviewed
May 4, 2026
Yicong-Huang
approved these changes
May 4, 2026
Contributor
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
Author
|
@Yicong-Huang, can you approve the two missing CI checks? |
Contributor
Let me see if I can make a command similar to |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4900 +/- ##
=========================================
Coverage 42.15% 42.16%
Complexity 2179 2179
=========================================
Files 980 980
Lines 36298 36305 +7
Branches 3783 3783
=========================================
+ Hits 15303 15308 +5
- Misses 20066 20068 +2
Partials 929 929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, or discussions?
closes: #4892
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.6 in Compliance with ASF