feat: Add Python Virtual Environment Support: Installing User Defined Packages#4902
Merged
Conversation
kunwp1
requested changes
May 4, 2026
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
The feature is working well! I left a few comments to improve the codebase and user experience.
…3/texera into pve-add-user-packages
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4902 +/- ##
============================================
- Coverage 42.78% 42.72% -0.07%
+ Complexity 2189 2186 -3
============================================
Files 1045 1045
Lines 39876 39979 +103
Branches 4205 4218 +13
============================================
+ Hits 17062 17080 +18
- Misses 21757 21838 +81
- Partials 1057 1061 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kunwp1
requested changes
May 5, 2026
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
Left a few more comments.
…3/texera into pve-add-user-packages
…3/texera into pve-add-user-packages
kunwp1
requested changes
May 12, 2026
Contributor
kunwp1
left a comment
kunwp1
left a comment
There was a problem hiding this comment.
Left more comments. Can you add more test cases that Codecov Report complains?
Also, this PR lacks sync check between requirements.txt and system-requirements-lock.txt. It's better to add a sync check in the github CI but totally up to you. If you are not going to add a github CI check on this PR, please mention it in the PR description and create an issue.
Contributor
Author
|
Thanks for the comments. I reviewed the Codecov report, and the current I also created issue #5034 to track adding a CI sync check between |
5 tasks
kunwp1
added a commit
that referenced
this pull request
May 13, 2026
…ed Packages (#5035) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR is an extension of PR #4484 and #4902. Previously, we introduced support for creating Python Virtual Environments (PVEs) with system-level dependencies preinstalled, along with support for installing user-defined packages. This PR extends that functionality by allowing users to uninstall user-installed packages from their PVEs. ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234` or `Closes #1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> This change is part of ongoing efforts to support environment isolation and reproducibility within Texera. Related issue includes #4296. This PR closes sub-issue #4466. ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Tested Manually and PveResourceSpec test file updated. To test: On CU click "+" Python Environments. Input environment name. Input package name and version. Click "OK" and wait for pip logs. To delete click on "Delete Icon" and click "OK" ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Co-authored using: ChatGPT (OpenAI) --------- Co-authored-by: Kunwoo (Chris) <143021053+kunwp1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR is an extension of PR #4484. Previously, we introduced support for creating Python Virtual Environments (PVEs) with system-level dependencies preinstalled. This PR builds on that foundation by enabling users to install custom Python packages within a PVE. In some cases, installing a user package may overwrite system-level packages. For this reason, System package versions are locked to prevent these conflicts.
Some duplicate lines of code (previously introduced in PR #4484) were removed from PveManager to improve clarity and reduce redundancy.
Any related issues, documentation, discussions?
This change is part of ongoing efforts to support environment isolation and reproducibility within Texera. Related issue includes #4296. This PR closes sub-issue #4465.
A GitHub CI sync check between
requirements.txtandsystem-requirements-lock.txtwill be added in a follow-up PR. Tracking issue: #5034.How was this PR tested?
Tested Manually and PveResourceSpec test file updated.
To test:
To test system dependency conflit management, install the following packages:
Was this PR authored or co-authored using generative AI tooling?
Co-authored using: ChatGPT (OpenAI)