Skip to content

feat(ui): add configuration for compute tab on admin page#4922

Merged
aglinxinyuan merged 4 commits into
apache:mainfrom
gracecluvohio:grace/admin-compute-config
May 4, 2026
Merged

feat(ui): add configuration for compute tab on admin page#4922
aglinxinyuan merged 4 commits into
apache:mainfrom
gracecluvohio:grace/admin-compute-config

Conversation

@gracecluvohio
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Adds admin configuration for compute tab.
image

Any related issues, documentation, discussions?

Closes #4921

How was this PR tested?

Locally

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions Bot added frontend Changes related to the frontend GUI common labels May 4, 2026
Copy link
Copy Markdown
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 4, 2026 08:58
@aglinxinyuan aglinxinyuan disabled auto-merge May 4, 2026 08:58
@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 4, 2026 08:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.98%. Comparing base (b562b55) to head (b91aa9a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onent/admin/settings/admin-settings.component.html 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4922      +/-   ##
============================================
- Coverage     42.10%   41.98%   -0.12%     
- Complexity     2175     2182       +7     
============================================
  Files           980      980              
  Lines         36292    36278      -14     
  Branches       3783     3783              
============================================
- Hits          15279    15233      -46     
- Misses        20091    20128      +37     
+ Partials        922      917       -5     
Flag Coverage Δ
access-control-service 39.53% <ø> (ø)
amber 43.04% <ø> (+0.05%) ⬆️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 33.24% <ø> (ø)
frontend 30.53% <83.33%> (+0.02%) ⬆️
workflow-compiling-service 47.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aglinxinyuan aglinxinyuan disabled auto-merge May 4, 2026 09:15
@aglinxinyuan aglinxinyuan enabled auto-merge (squash) May 4, 2026 09:21
@aglinxinyuan aglinxinyuan merged commit 94ab9c7 into apache:main May 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admin configuration for compute tab

4 participants