feat(ci): allow RC bundle to pin IMAGE_TAG to the git tag#4930
Merged
Conversation
Add a boolean workflow_dispatch input use_tag_as_image_tag (default false). When true, the bundled docker-compose .env pins IMAGE_TAG to the input git tag with the leading "v" stripped; otherwise it keeps the current 9-char commit-hash behavior. Closes apache#4929
bobbai00
added
the
release/v1.1.0-incubating
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4930 +/- ##
============================================
+ Coverage 42.15% 43.10% +0.95%
- Complexity 2179 2246 +67
============================================
Files 980 1011 +31
Lines 36298 40555 +4257
Branches 3783 4685 +902
============================================
+ Hits 15303 17483 +2180
- Misses 20066 21800 +1734
- Partials 929 1272 +343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aglinxinyuan
approved these changes
May 4, 2026
Contributor
|
Backport to |
Yicong-Huang
pushed a commit
that referenced
this pull request
May 4, 2026
(backported from commit c533305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Add a boolean
workflow_dispatchinputuse_tag_as_image_tag(defaultfalse) to.github/workflows/create-release-candidate.yml. When true, the bundled docker-compose.envpinsIMAGE_TAGto the input git tag with the leadingvstripped (e.g.v1.1.0-incubating-rc7→1.1.0-incubating-rc7); when false, the current 9-char commit-hash behavior is preserved.Any related issues, documentation, discussions?
Closes #4929.
How was this PR tested?
Workflow-only change. Verified shell logic locally:
TAG_NAME=v1.1.0-incubating-rc7; echo "${TAG_NAME#v}"→1.1.0-incubating-rc7.IMAGE_TAG=<commit_short>. Will be exercised end-to-end on the next RC run.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)