test: add specs for UserConfigService#5014
Merged
Merged
Conversation
…ervice # Conflicts: # frontend/angular.json # frontend/src/tsconfig.spec.json
Contributor
Author
|
@chenlica, please assign a reviewer |
Contributor
Yicong-Huang
approved these changes
May 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
============================================
+ Coverage 42.51% 42.65% +0.13%
Complexity 2192 2192
============================================
Files 1045 1045
Lines 39880 39880
Branches 4205 4205
============================================
+ Hits 16955 17010 +55
+ Misses 21869 21812 -57
- Partials 1056 1058 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM. |
…ervice # Conflicts: # frontend/angular.json # frontend/src/tsconfig.spec.json
…t/UserConfigService
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
`yarn format:ci` (prettier-eslint --list-different) flagged the file as unformatted in CI, breaking the frontend build. Auto-format removes a single trailing comma after the `include` array. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Replaces the commented-out user-config.service.spec.ts with a real Vitest suite that covers fetchAll, fetchKey, set, delete, change notifications, and login/logout reactions. Re-enables the spec in angular.json and tsconfig.spec.json.
Any related issues, documentation, or discussions?
Closes: #4964
How was this PR tested?
yarn ng test --include="**/user-config.service.spec.ts" All tests pass.
Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.7 in compliance with ASF.