fix: Revert "fix(auth): JwtAuthFilter eager-401 with @PermitAll opt-out"#5025
Merged
Conversation
Contributor
|
@kunwp1 please fill the PR template. give it some context so we know why we revert it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
=========================================
Coverage 42.64% 42.65%
- Complexity 2188 2191 +3
=========================================
Files 1045 1045
Lines 39880 39876 -4
Branches 4205 4205
=========================================
+ Hits 17006 17008 +2
+ Misses 21814 21808 -6
Partials 1060 1060
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
approved these changes
May 11, 2026
Contributor
Yicong-Huang
left a comment
There was a problem hiding this comment.
Thanks. you can just link the email in related discussion as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Reverts #4903 because it's causing a side-effect on the JWT authentication in ConfigService.
Any related issues, documentation, discussions?
Closes #5026
Email Discussion: https://lists.apache.org/thread/w5jmczrffxd5doc5hnss2zm7dbhnbhyy
How was this PR tested?
Run texera frontend in incognito mode (local cache cleared).
Was this PR authored or co-authored using generative AI tooling?
No.