Skip to content

fix: Revert "fix(auth): JwtAuthFilter eager-401 with @PermitAll opt-out"#5025

Merged
kunwp1 merged 1 commit into
mainfrom
revert-4903-refactor/jwt-filter-eager-401
May 11, 2026
Merged

fix: Revert "fix(auth): JwtAuthFilter eager-401 with @PermitAll opt-out"#5025
kunwp1 merged 1 commit into
mainfrom
revert-4903-refactor/jwt-filter-eager-401

Conversation

@kunwp1
Copy link
Copy Markdown
Contributor

@kunwp1 kunwp1 commented May 11, 2026

What changes were proposed in this PR?

Reverts #4903 because it's causing a side-effect on the JWT authentication in ConfigService.

Any related issues, documentation, discussions?

Closes #5026
Email Discussion: https://lists.apache.org/thread/w5jmczrffxd5doc5hnss2zm7dbhnbhyy

How was this PR tested?

Run texera frontend in incognito mode (local cache cleared).

Was this PR authored or co-authored using generative AI tooling?

No.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file common platform Non-amber Scala service paths labels May 11, 2026
@kunwp1 kunwp1 changed the title Revert "fix(auth): JwtAuthFilter eager-401 with @PermitAll opt-out" fix: Revert "fix(auth): JwtAuthFilter eager-401 with @PermitAll opt-out" May 11, 2026
@Yicong-Huang
Copy link
Copy Markdown
Contributor

@kunwp1 please fill the PR template. give it some context so we know why we revert it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.65%. Comparing base (14f8be4) to head (a25e9dc).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5025   +/-   ##
=========================================
  Coverage     42.64%   42.65%           
- Complexity     2188     2191    +3     
=========================================
  Files          1045     1045           
  Lines         39880    39876    -4     
  Branches       4205     4205           
=========================================
+ Hits          17006    17008    +2     
+ Misses        21814    21808    -6     
  Partials       1060     1060           
Flag Coverage Δ *Carryforward flag
access-control-service 39.53% <ø> (-0.35%) ⬇️
agent-service 33.72% <ø> (ø) Carriedforward from 14f8be4
amber 43.31% <ø> (+0.01%) ⬆️
computing-unit-managing-service 0.00% <ø> (ø)
config-service 0.00% <ø> (ø)
file-service 32.18% <ø> (+0.08%) ⬆️
frontend 33.85% <ø> (ø) Carriedforward from 14f8be4
python 88.90% <ø> (ø) Carriedforward from 14f8be4
workflow-compiling-service 47.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunwp1 kunwp1 requested a review from Yicong-Huang May 11, 2026 20:55
@kunwp1 kunwp1 enabled auto-merge (squash) May 11, 2026 20:58
Copy link
Copy Markdown
Contributor

@Yicong-Huang Yicong-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. you can just link the email in related discussion as well.

@kunwp1 kunwp1 merged commit 62d4489 into main May 11, 2026
24 of 25 checks passed
@kunwp1 kunwp1 deleted the revert-4903-refactor/jwt-filter-eager-401 branch May 11, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common dependencies Pull requests that update a dependency file platform Non-amber Scala service paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with the JWT authentication in ConfigService in the main branch

3 participants