feat: show MiB unit label next to size-based admin settings inputs#5066
Open
xuang7 wants to merge 7 commits into
Open
feat: show MiB unit label next to size-based admin settings inputs#5066xuang7 wants to merge 7 commits into
xuang7 wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
============================================
- Coverage 43.18% 42.87% -0.31%
+ Complexity 2209 2205 -4
============================================
Files 1045 1045
Lines 40262 40121 -141
Branches 4251 4239 -12
============================================
- Hits 17387 17202 -185
- Misses 21803 21859 +56
+ Partials 1072 1060 -12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Do we use Mib or Mb? This design choice may confuse users. We should convert to MB in the future. |
Contributor
Author
Currently we use MiB, following AWS conventions. We may convert to MB in the future if needed. |
Contributor
|
I didn't check details of the change yet. Could you please make coverage happy? We need to include more tests than manually doing so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds an inline
MiBunit label next to the size-based input boxes in the Admin Settings page, so the unit is visible at a glance without reading the help text below.Demo:

Any related issues, documentation, discussions?
Closes #5065
How was this PR tested?
Manually tested.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7