Skip to content

feat: show MiB unit label next to size-based admin settings inputs#5066

Open
xuang7 wants to merge 7 commits into
apache:mainfrom
xuang7:feat/show-mib-unit-on-size-inputs
Open

feat: show MiB unit label next to size-based admin settings inputs#5066
xuang7 wants to merge 7 commits into
apache:mainfrom
xuang7:feat/show-mib-unit-on-size-inputs

Conversation

@xuang7
Copy link
Copy Markdown
Contributor

@xuang7 xuang7 commented May 14, 2026

What changes were proposed in this PR?

This PR adds an inline MiB unit label next to the size-based input boxes in the Admin Settings page, so the unit is visible at a glance without reading the help text below.

Demo:
unit-added

Any related issues, documentation, discussions?

Closes #5065

How was this PR tested?

Manually tested.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Opus 4.7

@github-actions github-actions Bot added feature frontend Changes related to the frontend GUI labels May 14, 2026
@xuang7 xuang7 changed the title feat: show MiB unit label next to size-based admin settings inputs feat: show MiB unit label next to size-based admin settings inputs May 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.87%. Comparing base (9422def) to head (1390c04).

Files with missing lines Patch % Lines
...onent/admin/settings/admin-settings.component.html 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5066      +/-   ##
============================================
- Coverage     43.18%   42.87%   -0.31%     
+ Complexity     2209     2205       -4     
============================================
  Files          1045     1045              
  Lines         40262    40121     -141     
  Branches       4251     4239      -12     
============================================
- Hits          17387    17202     -185     
- Misses        21803    21859      +56     
+ Partials       1072     1060      -12     
Flag Coverage Δ *Carryforward flag
access-control-service 39.53% <ø> (ø) Carriedforward from f2355df
agent-service 33.72% <ø> (ø) Carriedforward from f2355df
amber 43.71% <ø> (-0.14%) ⬇️ Carriedforward from f2355df
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from f2355df
config-service 0.00% <ø> (ø) Carriedforward from f2355df
file-service 32.18% <ø> (ø) Carriedforward from f2355df
frontend 34.08% <80.00%> (+<0.01%) ⬆️
python 89.14% <ø> (-1.35%) ⬇️ Carriedforward from f2355df
workflow-compiling-service 47.72% <ø> (-9.10%) ⬇️ Carriedforward from f2355df

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ma77Ball
Copy link
Copy Markdown
Contributor

Do we use Mib or Mb? This design choice may confuse users. We should convert to MB in the future.

@xuang7
Copy link
Copy Markdown
Contributor Author

xuang7 commented May 14, 2026

Do we use Mib or Mb? This design choice may confuse users. We should convert to MB in the future.

Currently we use MiB, following AWS conventions. We may convert to MB in the future if needed.

@Yicong-Huang
Copy link
Copy Markdown
Contributor

I didn't check details of the change yet. Could you please make coverage happy? We need to include more tests than manually doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show unit labels next to size-based admin settings inputs

4 participants