fix: drop withDefaultValue from StatisticsManager so checkpoint state round-trips#5150
Merged
Merged
Conversation
add /sub-issue, /parent-issue, and unlink variants to comment-commands
Contributor
Author
|
/request-review @aglinxinyuan |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5150 +/- ##
============================================
- Coverage 43.36% 43.34% -0.03%
+ Complexity 2217 2211 -6
============================================
Files 1049 1049
Lines 40560 40558 -2
Branches 4322 4320 -2
============================================
- Hits 17589 17580 -9
- Misses 21883 21888 +5
- Partials 1088 1090 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
approved these changes
May 22, 2026
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
Changes direction looks correct. I wonder if it has issues with existing DBs (for the checkpointed and persisted states).
Added a comment regarding DataProcessor in StatisticsManager. Signed-off-by: Matthew B. <mgball@uci.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
StatisticsManagerdeclared its input/output stats maps asmutable.Map.empty.withDefaultValue((0L, 0L)). The resultingMap.WithDefaultwrapper does not survive a Kryo round-trip (its inner map deserializes as null), sochkpt.load(CP_STATE_KEY)on a default-stateControllerProcessorthrowsKryoException: NullPointerException, blockingController.loadFromCheckpointfrom ever rehydrating a checkpointed controller. This PR removes the wrapper and inlinesgetOrElse(portId, (0L, 0L))at the two write sites; behavior is unchanged.Any related issues, documentation, or discussions?
closes: #4686
How was this PR tested?
Replaced the two existing
should be serializablecases inCheckpointSpecwith full save then load round-trips (controller + worker) that assertrestored.actorId == original.actorId; the new tests reproduce the original NPE onmainand pass after the fix. Verified locally withsbt 'WorkflowExecutionService / Test / testOnly org.apache.texera.amber.engine.faulttolerance.CheckpointSpec'(3/3 pass).Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF