feat(dashboard): add public dataset card view#5215
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5215 +/- ##
==========================================
Coverage 48.34% 48.35%
+ Complexity 2345 2344 -1
==========================================
Files 1042 1045 +3
Lines 39974 40153 +179
Branches 4251 4282 +31
==========================================
+ Hits 19327 19414 +87
- Misses 19505 19586 +81
- Partials 1142 1153 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I find myself not liking the cover image for a dataset. in fact in real usage, it's unlikely for a user to spend time to find a cover image for a dataset: it will likely become the default image instead. Thus I suggest remove the image, or at least make it optional. |
|
@xuang7 could you please also add more tests to make coverage happy? thanks! |
Thanks for the suggestion! I agree that many datasets may not have a custom cover image in real usage, and it is possible that most of them will fall back to the default image, similar to what we currently have on the Hub featured workflow.
I think the image area helps make the card view more visually distinguishable, since we do not have many metadata fields yet, such as tags, dataset format, or subtitle/summary information. Without an image, the cards may look a bit plain and information-heavy. That said, we could also make the image optional, use a more compact layout where the cover image takes up a smaller portion of the card, like the attached example, or remove it entirely. I'm open to adjusting the design.
I will add more tests to improve the coverage. I'm still considering whether to split this into two smaller PRs since the current PR is getting a bit large. Thanks! @Yicong-Huang |
|
@xuang7 I think you need to create an issue. after a discussion, when we have consensus to do something or go with a direction, please create an issue as "To do task" to track it. The discussion could contain back and forth conversations. the issue serves as a "decision" or "summary". on this particular case, the discussion in #5130 only covers list vs cards. I think (based on my reading) the card view got the most votes. but the details of the card was never discussed. it might be fine, but that might be the reason we are doing discussion here in the PR about what info to put inside the card (i.e., image or not). |
Sounds good. I will do another round of voting to reach a final decision, and create a separate issue related to this PR to summarize and track the card view design details. Thanks for the suggestions! |
we don't need a vote (too official), but good to discuss design before start. just want to avoid waste of implementing PR and reviews. |
Yes, that makes sense. By "voting," I meant that I will add a proposed design solution to the discussion/issue and see if there are more comments or suggestions about the design. |
|
I agree that no official vote is needed. |



What changes were proposed in this PR?
This PR adds a card view to the dataset listing, with a toggle to switch between the existing list view and the new card view for public dataset. Applied to the public dataset listing (/dashboard/hub/dataset/result).
Changes:
card branch is gated on viewMode === 'card' && cardTemplate.
Any related issues, documentation, discussions?
Discussion #5130
Related to #4216 (workflow card view; same framework can later be applied).
Follow-up TODOs:
How was this PR tested?
Added test cases and manually tested.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7