refactor: consolidate count and relative-time formatting utilities#5220
Open
xuang7 wants to merge 3 commits into
Open
refactor: consolidate count and relative-time formatting utilities#5220xuang7 wants to merge 3 commits into
xuang7 wants to merge 3 commits into
Conversation
github-actions
Bot
added
refactor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
============================================
+ Coverage 48.57% 48.67% +0.09%
Complexity 2379 2379
============================================
Files 1042 1043 +1
Lines 39971 39977 +6
Branches 4252 4252
============================================
+ Hits 19415 19457 +42
+ Misses 19410 19376 -34
+ Partials 1146 1144 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
Good change! But I would kindly ask you to provide tests for all those format utils. The coverage is quite low currently.
| return new Date(timestamp).toLocaleDateString(); | ||
| } | ||
| } | ||
| formatRelativeTime = formatRelativeTime; |
Contributor
There was a problem hiding this comment.
Just wonder why are these rename to the same name needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR extracts duplicated
formatCountand relative-time formatting logic into the sharedformat.util.tsutility file, and updates inline usages to use the shared utilities. No behavior change.Any related issues, documentation, discussions?
Closes #5218
How was this PR tested?
Existing automated tests passed.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7