fix: honor Option contract on tryGetExistingExecution miss#5221
Merged
Yicong-Huang merged 3 commits intoMay 26, 2026
Conversation
…xisting-some-null # Conflicts: # amber/src/test/scala/org/apache/texera/web/service/ExecutionsMetadataPersistServiceSpec.scala
Contributor
Author
|
/request-review @aglinxinyuan |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5221 +/- ##
============================================
- Coverage 48.55% 48.54% -0.02%
+ Complexity 2372 2370 -2
============================================
Files 1042 1042
Lines 39971 39971
Branches 4252 4252
============================================
- Hits 19408 19403 -5
- Misses 19414 19418 +4
- Partials 1149 1150 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
tryGetExistingExecutioninExecutionsMetadataPersistServiceto wrap the DAO call withOption(...)instead ofSome(...), so a missing row (jOOQ returnsnull) collapses toNonerather thanSome(null).catch Throwableblock, which still earns its keep for hard DB errors (e.g. closed connection); theOptionwrap only addresses the no-row miss path.ExecutionsMetadataPersistServiceSpec(added in test(amber): DB-backed unit tests for ExecutionsMetadataPersistService and updateWorkflowState #5213): replace the two paired pin tests (theSome(null)pin and the invertedintercept[TestFailedException]xfail-strict) with a single positiveshouldBe Nonetest.Any related issues, documentation, or discussions?
Closes: #5211. Depends on #5213 (test scaffolding); rebase after it lands.
How was this PR tested?
sbt scalafmtAll(no rewrites needed).ExecutionsMetadataPersistServiceSpec.tryGetExistingExecutionnow has positive tests for both the hit (Some(row)) and the miss (None) cases.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF