test: unit tests for LocalLoginComponent#5235
Open
Ma77Ball wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
local-login.component.spec.tsto cover form construction, validators, default-user prefill, and the login/register flows that were previously untested.allFormsexposes the five expected controls withrequired,minLength(6), and the customconfirmationValidator, thatconfirmationValidatorreturns{ confirm: true }on mismatch and{}on match, and thatupdateConfirmValidatorschedulesupdateValueAndValidityon the confirmation control viasetTimeout.ngOnInitpatchesloginUsername/loginPasswordonly whenGuiConfigService.env.defaultLocalUseris populated, thatloginshort-circuits vialoginErrorMessageon validation failure and otherwise callsUserService.loginwith the trimmed username and navigates toqueryParams.returnUrlorDASHBOARD_USER_WORKFLOW, and that error paths surface the error's message (or the fallback"Incorrect username or password") throughNotificationService.error.registerenforces password length, password match, andUserService.validateUsername, callsUserService.registerwith the trimmed username on success and surfaces the account-created notification, and on error notifies with the error's message (or the fallback"Registration failed").Any related issues, documentation, or discussions?
Closes: #5226
How was this PR tested?
yarn test --include="src/app/hub/component/about/local-login/local-login.component.spec.ts", 22 tests passing.yarn format:fix, 506 files unchanged.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF