test: cover SearchBarComponent debounce, cache, and routing#5237
Open
Ma77Ball wants to merge 1 commit into
Open
test: cover SearchBarComponent debounce, cache, and routing#5237Ma77Ball wants to merge 1 commit into
Ma77Ball wants to merge 1 commit into
Conversation
Ma77Ball
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
search-bar.component.spec.tsnext tosearch-bar.component.tswith 11 cases covering every documented behavior of the component.isLogininitialization plus live updates fromUserService.userChanged(), the empty-query clear path inonSearchInputChange,searchSubjectdebounce viafakeAsync+tick(200), the fullSearchService.searchargument list, per-query result caching, 20-entry cache eviction inaddToCache, type dispatch inconvertToName(workflow, project, file, dataset, plus the throw path), andperformSearchnavigation toDASHBOARD_SEARCH.Any related issues, documentation, or discussions?
Closes: #5228
How was this PR tested?
yarn ng test --watch=false --include "src/app/dashboard/component/user/search-bar/search-bar.component.spec.ts": 11 passed.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF