feat(python-notebook-migration, config): add python-notebook-migration-enabled feature flag#5254
Open
zyratlo wants to merge 4 commits into
Open
feat(python-notebook-migration, config): add python-notebook-migration-enabled feature flag#5254zyratlo wants to merge 4 commits into
zyratlo wants to merge 4 commits into
Conversation
# Conflicts: # common/config/src/main/scala/org/apache/texera/config/GuiConfig.scala # config-service/src/main/scala/org/apache/texera/service/resource/ConfigResource.scala # frontend/src/app/common/type/gui-config.ts
github-actions
Bot
added
frontend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5254 +/- ##
============================================
- Coverage 48.95% 48.95% -0.01%
- Complexity 2377 2378 +1
============================================
Files 1048 1048
Lines 40270 40271 +1
Branches 4272 4272
============================================
Hits 19714 19714
- Misses 19402 19403 +1
Partials 1154 1154
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zyratlo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Introduces a feature flag
python-notebook-migration-enabled(defaultfalse) that will gate the upcoming Python-notebook to Texera-workflow migration tool. No user-visible behavior changes, the flag controls features that don't exist onmainyet.common/config/src/main/resources/gui.conf— declaregui.workflow.workspace.python-notebook-migration-enabled = false, with env-var overrideGUI_WORKFLOW_WORKSPACE_PYTHON_NOTEBOOK_MIGRATION_ENABLED.common/config/src/main/scala/org/apache/texera/config/GuiConfig.scala— Scala accessor for the new field.…/service/resource/ConfigResource.scala— include the flag in the runtime config payload served to the frontend.frontend/src/app/common/type/gui-config.ts— add the typed field on the frontendGuiConfiginterface.frontend/src/app/workspace/component/menu/menu.component.ts— expose apythonNotebookMigrationEnabledgetter for downstream migration-tool UI to consume.Any related issues, documentation, discussions?
Closes #5253
Parent issue #4301
How was this PR tested?
/api/configpayloadMenuComponent.pythonNotebookMigrationEnabledresolvesWas this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)