fix(dataset): load cover image on detail page for private datasets#5284
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5284 +/- ##
=========================================
Coverage 49.12% 49.12%
- Complexity 2378 2379 +1
=========================================
Files 1051 1051
Lines 40348 40350 +2
Branches 4279 4279
=========================================
+ Hits 19821 19822 +1
- Misses 19368 19369 +1
Partials 1159 1159
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes the cover image failing to load on the dataset detail page for private datasets, and removes the default placeholder shown when no cover image is set.
Changes:
GET /dataset/{did}/cover-urlthat returns the presigned S3 URL as JSON. The detail page calls it via AngularHttpClient(which carries the JWT), then sets the returned URL on<img src>(presigned URL needs no auth)./coveris preserved for the hub browse page, which serves only public datasets and consumes the redirect directly. Both endpoints now have doc comments cross-referencing each other.Demo:

With cover image:
Without cover image:

Any related issues, documentation, discussions?
Closes #5283
How was this PR tested?
Added test cases for the new endpoint.
Manually verified on a local instance.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7