Skip to content

refactor: Remove dead project routing#5309

Closed
Ma77Ball wants to merge 1 commit into
apache:mainfrom
Ma77Ball:removeProjectRouting
Closed

refactor: Remove dead project routing#5309
Ma77Ball wants to merge 1 commit into
apache:mainfrom
Ma77Ball:removeProjectRouting

Conversation

@Ma77Ball
Copy link
Copy Markdown
Contributor

@Ma77Ball Ma77Ball commented Jun 1, 2026

What changes were proposed in this PR?

  • Removed the project and project/:pid route definitions from app-routing.module.ts, along with the now-unused UserProjectComponent and UserProjectSectionComponent imports there.
  • Removed the type === "project" arm from ListItemComponent.initializeEntry and dropped its now-unused DASHBOARD_USER_PROJECT import.

Any related issues, documentation, or discussions?

Closes: #5172

How was this PR tested?

  • Ran yarn format:fix (clean, 514 files unchanged).
  • Verified via grep that no project route or DASHBOARD_USER_PROJECT references remain in the two edited files.
  • The referenced list-item.component.spec.ts project routing test case was already absent, so no spec change was needed.

Was this PR authored or co-authored using generative AI tooling?

Co-authored with Claude Opus 4.7 in compliance with ASF

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label Jun 1, 2026
@Ma77Ball Ma77Ball changed the title Remove dead project routing fix: Remove dead project routing Jun 1, 2026
@Ma77Ball Ma77Ball changed the title fix: Remove dead project routing refactor: Remove dead project routing Jun 1, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.95%. Comparing base (eb287f3) to head (db843e3).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5309      +/-   ##
============================================
- Coverage     49.97%   49.95%   -0.02%     
  Complexity     2421     2421              
============================================
  Files          1052     1052              
  Lines         40780    40777       -3     
  Branches       4356     4355       -1     
============================================
- Hits          20378    20369       -9     
- Misses        19193    19196       +3     
- Partials       1209     1212       +3     
Flag Coverage Δ *Carryforward flag
access-control-service 41.89% <ø> (ø) Carriedforward from eb287f3
agent-service 33.76% <ø> (ø) Carriedforward from eb287f3
amber 52.01% <ø> (ø) Carriedforward from eb287f3
computing-unit-managing-service 1.38% <ø> (ø) Carriedforward from eb287f3
config-service 54.68% <ø> (ø) Carriedforward from eb287f3
file-service 38.42% <ø> (ø) Carriedforward from eb287f3
frontend 42.40% <ø> (-0.03%) ⬇️
pyamber 90.80% <ø> (ø) Carriedforward from eb287f3
python 90.80% <ø> (ø) Carriedforward from eb287f3
workflow-compiling-service 58.39% <ø> (ø) Carriedforward from eb287f3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ma77Ball
Copy link
Copy Markdown
Contributor Author

Ma77Ball commented Jun 1, 2026

/request-review @Xiao-zhen-Liu

@github-actions github-actions Bot requested a review from Xiao-zhen-Liu June 1, 2026 20:57
@Yicong-Huang
Copy link
Copy Markdown
Contributor

hmm, I thought we agreed to hold off on the issue. were there any updates on the decision?

@Ma77Ball
Copy link
Copy Markdown
Contributor Author

Ma77Ball commented Jun 2, 2026

@Yicong-Huang Yes, the plan currently is to avoid removing project routing until a formal decision is made. I wanted this to be a draft pr, but I did not see this option when opening this pr.

@Ma77Ball Ma77Ball closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove project routing from the user dashboard

3 participants