Skip to content

Comments

TEZ-4294. Tez UI counters missing in settings view#144

Merged
abstractdog merged 1 commit intoapache:masterfrom
jteagles:TEZ-4294
Dec 25, 2021
Merged

TEZ-4294. Tez UI counters missing in settings view#144
abstractdog merged 1 commit intoapache:masterfrom
jteagles:TEZ-4294

Conversation

@jteagles
Copy link
Contributor

No description provided.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 4m 31s Maven dependency ordering for branch
+1 💚 mvninstall 10m 21s master passed
+1 💚 compile 1m 39s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 1m 43s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 5s master passed
+1 💚 javadoc 1m 18s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 1m 6s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 spotbugs 1m 5s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 1m 5s branch/tez-ui no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 19s the patch passed
+1 💚 jshint 11m 29s There were no new jshint issues.
+1 💚 compile 1m 39s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 1m 39s the patch passed
+1 💚 compile 1m 33s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 1m 33s the patch passed
+1 💚 checkstyle 0m 39s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 50s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 0m 53s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗 findbugs 1m 0s tez-ui has no data from findbugs
_ Other Tests _
+1 💚 unit 2m 12s tez-api in the patch passed.
+1 💚 unit 2m 10s tez-ui in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
54m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-144/1/artifact/out/Dockerfile
GITHUB PR #144
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile jshint
uname Linux 1681c1d348a4 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fc63c04
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-144/1/testReport/
Max. process+thread count 247 (vs. ulimit of 5500)
modules C: tez-api tez-ui U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-144/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1 jshint=2.12.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteagles
Copy link
Contributor Author

@abstractdog, could you have a look at this small patch. Keeps Tez UI in sync with Task and DAG counters.

@abstractdog abstractdog self-requested a review October 17, 2021 16:43
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
double-checked by locally running TezUI with and without the patch

wondering if we can introduce a unit test on tez-api or tez-ui side to avoid this kind of divergence in the future, it is worth a follow-up ticket

@abstractdog abstractdog merged commit bf616b2 into apache:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants